Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Remove subshells windows #58
Following the modifications of Pull #57, I would like make extensive the change to remove subshells for Windows too.
Shelling out to perform the lookup was even more expensive than POSIX.
What was done here is remove the dependency on
The approach taken will append '.exe' to supplied cmd name under Windows.
Only .exe are truly executables and anything else (.bat, .vbs, .msc) can't be executed directly.
To execute batch files (.bat, .cmd), Ruby wraps them with cmd.exe.
Based on existing executables on the platform (node.exe, cscript.exe) and that .com hasn't been seen in the past 10 years (only for compatibility), the lookup over PATHEXT seems unnecessary.
I've also removed the support batch file since is no longer necessary.