Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP
Browse files

Work around an issue with `Element.cumulativeOffset` that was affecti…

…ng sortable behavior in script.aculo.us. (sam, Andrew Dupont)
  • Loading branch information...
commit 544d2ce1de6ffacd4a498eb91ba3c9966506484e 1 parent b1f4f28
@savetheclocktower savetheclocktower authored
Showing with 4 additions and 2 deletions.
  1. +2 −0  CHANGELOG
  2. +2 −2 src/deprecated.js
View
2  CHANGELOG
@@ -1,3 +1,5 @@
+* Work around an issue with `Element.cumulativeOffset` that was affecting sortable behavior in script.aculo.us. (sam, Andrew Dupont)
+
*1.7_rc1* (April 1, 2010)
* Add an `Event.Handler` class, plus `Event.on` and `Element#on` methods, for simplified event delegation. (sam, Tobie Langel, Andrew Dupont)
View
4 src/deprecated.js
@@ -64,8 +64,8 @@ var Position = {
withinIncludingScrolloffsets: function(element, x, y) {
var offsetcache = Element.cumulativeScrollOffset(element);
@tiff
tiff added a note

I think this line is now obsolete, right?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
- this.xcomp = x + offsetcache[0] - this.deltaX;
- this.ycomp = y + offsetcache[1] - this.deltaY;
+ this.xcomp = x - this.deltaX;
+ this.ycomp = y - this.deltaY;
this.offset = Element.cumulativeOffset(element);
return (this.ycomp >= this.offset[1] &&
Please sign in to comment.
Something went wrong with that request. Please try again.