Skip to content
This repository
Browse code

Revert "Work around an issue with `Element.cumulativeOffset` that was…

… affecting sortable behavior in script.aculo.us. (sam, Andrew Dupont)"

This reverts commit 544d2ce.
  • Loading branch information...
commit 8456c981da5ccdde4ef22a20e2aa52d68d2d52bf 1 parent 0b108e2
Sam Stephenson authored

Showing 2 changed files with 2 additions and 4 deletions. Show diff stats Hide diff stats

  1. +0 2  CHANGELOG
  2. +2 2 src/deprecated.js
2  CHANGELOG
... ... @@ -1,5 +1,3 @@
1   -* Work around an issue with `Element.cumulativeOffset` that was affecting sortable behavior in script.aculo.us. (sam, Andrew Dupont)
2   -
3 1 *1.7_rc1* (April 1, 2010)
4 2
5 3 * Add an `Event.Handler` class, plus `Event.on` and `Element#on` methods, for simplified event delegation. (sam, Tobie Langel, Andrew Dupont)
4 src/deprecated.js
@@ -64,8 +64,8 @@ var Position = {
64 64 withinIncludingScrolloffsets: function(element, x, y) {
65 65 var offsetcache = Element.cumulativeScrollOffset(element);
66 66
67   - this.xcomp = x - this.deltaX;
68   - this.ycomp = y - this.deltaY;
  67 + this.xcomp = x + offsetcache[0] - this.deltaX;
  68 + this.ycomp = y + offsetcache[1] - this.deltaY;
69 69 this.offset = Element.cumulativeOffset(element);
70 70
71 71 return (this.ycomp >= this.offset[1] &&

0 comments on commit 8456c98

Please sign in to comment.
Something went wrong with that request. Please try again.