Event.findElement causes error if nothing matches the given pattern

[jamis]

If you call Event.findElement with a pattern that doesn't match any elements in the ancestor chain, you get an error (in Chrome and FF) caused by getAttribute() being called on the root HTML document object, which doesn't have a getAttribute method. It is easily reproducible:

<script type="text/javascript" src="/javascripts/prototype.js"></script> <script type="text/javascript"> function clickme(event) { try { alert(event.findElement('[bogus-attr]')); } catch(e) { alert(e); } } </script> Click me!

For now, I'm working around this by putting a try/catch around findElement calls.

[dandean]

Hi Jamis,

Wouldn't the correct selector be event.findElement('*[bogus-attr]').

In any event, I'm going to move this report over to the lighthouse. Thanks!

[dandean]

Jamis, you can track progress on this issue here:

https://prototype.lighthouseapp.com/projects/8886-prototype/tickets/999

Please post any future issues over on the lighthouse project.

[jamis]

Oh, didn't know about '*[blah]'. I guess I figured if the syntax was invalid, the selector would have failed earlier. :) Thanks for moving it to lighthouse, wasn't sure where the right place to report this was.

[tobie]

That's a Sizzle bug, I'm afraid.