Fix memory leak in stopObserving when it may keep a reference to watched elements forever (until page reload)#21
Closed
kir wants to merge 2 commits into
Closed
Fix memory leak in stopObserving when it may keep a reference to watched elements forever (until page reload)#21kir wants to merge 2 commits into
kir wants to merge 2 commits into
Conversation
…hed elements forever (until page reload)
Contributor
Author
|
My original fix introduced a performance problem with stopObserving call. Now, this problem is fixed. |
Collaborator
|
I just merged my rewrite of |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
The existing code of stopObserving doesn't cleanup CACHE variable which is used to cleanup all observers on page unload. Even if I detach all handlers from an element using stopObserving(), the CACHE variable will still have a reference to the element (and the whole tree).
The proposed patch fixes the problem.
Thanks,
KIR