In PeriodicalExcuter, removed unnecessary currentlyExecuting ivar and other code relating to parallel execution.
Since #onTimerEvent contained no logic after this change, made setInterval call (a bound) #execute and renamed #registerCallback to #start so that the timer can be restarted at will. This behavior already existed in the previous (undocumented) function.
In PeriodicalExcuter, removed unnecessary `currentlyExecuting` ivar a…
…nd other code relating to parallel execution.
Check to ensure that `this.timer` doesn't exist before assigning it i…
Didn't seem like this was performing any function that the previous test wasn't already doing, given that currentlyExecuting was removed.
Mind merging or closing?
I'm guessing they've given up over here
Sorry — we dropped the ball on pull requests for a while.
Just want to make sure I'm not missing something here.
HAHAHA DISREGARD THAT (now I see your point)
Just shows how little this code has been touched over the years. Yeah, it doesn't prevent callback accumulation, and it's quite silly of us to have pretended that it did.
So I have four options, as I see it:
I am leaning towards option #4 because we can't get rid of PeriodicalExecuter (backward compatibility), and as long as we're stuck with it I think it should serve some purpose beyond setInterval.