Additional tests for Element#makeClipping(), Element#undoClipping() #46

Open
wants to merge 1 commit into
from

Conversation

Projects
None yet
2 participants
@victor-homyakov
Contributor

victor-homyakov commented Mar 6, 2012

See ticket #1063:

  1. Current implementation doesn't work properly for inline style="overflow:auto;"
  2. Inline style isn't restored properly after undoClipping() - it is replaced with computed style
  3. Computing style with Element.getStyle() isn't needed - performance optimization is possible
@savetheclocktower

This comment has been minimized.

Show comment Hide comment
@savetheclocktower

savetheclocktower Aug 27, 2012

Collaborator

I'll use these tests to help me fix #1063. Until then, I'll keep this open because I don't want to commit tests without the fix that will make them pass. Thanks!

Collaborator

savetheclocktower commented Aug 27, 2012

I'll use these tests to help me fix #1063. Until then, I'll keep this open because I don't want to commit tests without the fix that will make them pass. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment