Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

viewportOffset: extend forElement (it's used twice) #87

Merged
merged 1 commit into from Dec 26, 2012

Conversation

Projects
None yet
3 participants
Contributor

victor-homyakov commented Dec 25, 2012

forElement was used twice in viewportOffset:

  1. at line 1147 as var element = $(forElement);
  2. at line 1156 as element = forElement;
    This leads to error when forElement is string: Element.viewportOffset('id')
@victor-homyakov victor-homyakov viewportOffset: extend forElement (it's used twice)
`forElement` was used twice in `viewportOffset`:
1. at line 1147 as `var element = $(forElement);`
2. at line 1156 as `element = forElement;`
This leads to error when `forElement` is string: `Element.viewportOffset('id')`
a8f0434

@savetheclocktower savetheclocktower added a commit that referenced this pull request Dec 26, 2012

@savetheclocktower savetheclocktower Merge pull request #87 from victor-homyakov/patch-31
Prevent error in `Element.viewportOffset` when string is passed as first argument.
fe2b76f

@savetheclocktower savetheclocktower merged commit fe2b76f into sstephenson:master Dec 26, 2012

@victor-homyakov victor-homyakov deleted the victor-homyakov:patch-31 branch Nov 25, 2013

This fixed issues for us which cropped up in the latest release of Chrome (v 32.0.17)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment