Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

SassImporter is not marshalable. #507

Closed
cheald opened this Issue · 3 comments

4 participants

Chris Heald Judson Lester Justin Smestad Adrien Coquio
Chris Heald

Per https://github.com/nex3/sass/blob/master/lib/sass/importers/base.rb#L17 importers should be marshalable. Sprockets::SassImporter has @context which is not serializable. This breaks sass' caching.

Per @spohlenz's suggestion, the correct fix would be to define #_dump and ::_load on Sprockets::SassImporter so that it can be marshaled and restored. This significantly improves the repeated compilation speed of Sass 3.3.0 under Sprockets.

See the recent discussion on rails/sass-rails#36 for more detailed information.

Judson Lester

I've implemented a temporary fix here: https://github.com/LRDesign/sass-rails-source-maps

But the right fix would be to correct this in Sprockets.

Justin Smestad

:+1: would love to see this fixed!

Adrien Coquio

:+1: me too !

Joshua Peek josh closed this issue from a commit
Joshua Peek josh Disable sass cache store
Custom importer can't be serialized.

Closes #507
655f129
Joshua Peek josh closed this in 655f129
Joshua Peek josh locked and limited conversation to collaborators
Chris Nicola chrisnicola referenced this issue from a commit in LRDesign/sass-rails-source-maps
Judson Lester nyarly Preliminary version of forked gem 11465d8
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Something went wrong with that request. Please try again.