Skip to content
This repository has been archived by the owner on Jun 10, 2018. It is now read-only.

"invalid byte sequence in #{__ENCODING__}" because of directive_processor #412

Closed
wants to merge 3 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 5 additions & 1 deletion lib/sprockets/directive_processor.rb
Expand Up @@ -91,7 +91,11 @@ def prepare
def evaluate(context, locals, &block)
@context = context

@result = ""
@result = if context.environment.respond_to?(:default_external_encoding) #encoding aware ruby?
"".encode(context.environment.default_external_encoding)
else
""
end
@has_written_body = false

process_directives
Expand Down
1 change: 1 addition & 0 deletions test/fixtures/context/utf8.js.erb
@@ -0,0 +1 @@
console.log("Snowman: <%= "\xe2\x98\x83" %>")
13 changes: 13 additions & 0 deletions test/test_directive_processor.rb
Expand Up @@ -108,6 +108,19 @@ def directives(offset = 0)
end
end

if "".respond_to?(:encoding)
class TestDirectiveProcessorEncoding < Sprockets::TestCase
def setup
@env = Sprockets::Environment.new
@env.append_path(fixture_path('context'))
end

test "encoding of evaluated string" do
assert_equal Encoding::UTF_8, @env['utf8.js'].source.encoding
end
end
end

class TestCustomDirectiveProcessor < Sprockets::TestCase
def setup
@env = Sprockets::Environment.new
Expand Down