This repository was archived by the owner on Jun 10, 2018. It is now read-only.
add package.json to search path for packages that do not use bower.json#484
Closed
shioyama wants to merge 1 commit into
Closed
add package.json to search path for packages that do not use bower.json#484shioyama wants to merge 1 commit into
shioyama wants to merge 1 commit into
Conversation
…on or component.json.
Contributor
|
Sorry, 👎 |
Author
|
I figured that was the reason, but is there a concrete scenario where this would cause problems? The only alternative I can see is to track down the maintainers of every package and get them to add a bower.json file. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A lot of packages use
package.jsoninstead ofbower.json, but AFAICT the basic setup is the same, with the main file indicated undermain.Maybe I'm missing something but it would seem useful to add package.json to the search path as I have here, to handle that case.