Fix Websocket #88
Merged
Fix Websocket #88
Conversation
Please allow a bit of time to inspect, I'm afraid your changes would break other implementations. |
Never mind what I said, not enough coffee yet |
It would break old implementations. But I suppose old implementations are now way too old to support. And new implementation (openfire) dont work without above changes. So better to support new implementation then old. :) |
Yes, 100% agree.
… On 13 Mar 2018, at 10:20, Amish ***@***.***> wrote:
It would break old implementations. But I suppose old implementations are now way too old to support.
And new implementation (openfire) dont work without above changes. So better to support new implementation then old. :)
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub <#88 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AABc6n2RiThQj8zt66yKgp7vx7tljfqEks5td49WgaJpZM4Smg2i>.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
This fixes Websocket connections by using
<open/>
and<close/>
instead of using<stream:stream/>.
Tested with openfire version 4.2.2 and jwchat. (with little modification to use websocket)