Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Websocket #88

Merged
merged 1 commit into from Mar 13, 2018
Merged

Fix Websocket #88

merged 1 commit into from Mar 13, 2018

Conversation

@amishmm
Copy link

@amishmm amishmm commented Mar 12, 2018

This fixes Websocket connections by using <open/> and <close/> instead of using <stream:stream/>.

Tested with openfire version 4.2.2 and jwchat. (with little modification to use websocket)

@sstrigler
Copy link
Owner

@sstrigler sstrigler commented Mar 13, 2018

Please allow a bit of time to inspect, I'm afraid your changes would break other implementations.

@sstrigler sstrigler merged commit 64ce30f into sstrigler:master Mar 13, 2018
@sstrigler
Copy link
Owner

@sstrigler sstrigler commented Mar 13, 2018

Never mind what I said, not enough coffee yet

@amishmm
Copy link
Author

@amishmm amishmm commented Mar 13, 2018

It would break old implementations. But I suppose old implementations are now way too old to support.

And new implementation (openfire) dont work without above changes. So better to support new implementation then old. :)

@sstrigler
Copy link
Owner

@sstrigler sstrigler commented Mar 13, 2018

@amishmm amishmm deleted the amishmm:websocket branch Mar 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants