Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

invalid in react 0.14.X? #44

Closed
beiciye opened this issue May 9, 2016 · 8 comments
Closed

invalid in react 0.14.X? #44

beiciye opened this issue May 9, 2016 · 8 comments

Comments

@beiciye
Copy link

beiciye commented May 9, 2016

Hi ! Must it need react 0.15.X? We need to support IE8 in the project.

@sstur
Copy link
Owner

sstur commented May 9, 2016

Hi @beiciye. I actually have no issue with supporting react 0.14.x. The reason we bumped it to v15.x was because there were issues in v0.14 with Warning: A component is 'contentEditable' and contains 'children' managed by React which was causing some bug reports.

I can probably change the requirement to support v0.14 or v15 but to be honest you will have issues with using this project in IE8 anyway. I doubt draft-js will support versions of IE that old and I have been using Flexbox and similar features that are IE10 and newer.

@vitosamson
Copy link

In my current project we're not supporting IE8 but we haven't yet made the jump to react v15. It would be really great if you could add 0.14 as a valid peer dependency.

@beiciye
Copy link
Author

beiciye commented May 9, 2016

@sstur I got it . Thank you!

@beiciye
Copy link
Author

beiciye commented May 10, 2016

@sstur I have noticed you make a PR to support images , but I didn't find those files.

@sstur
Copy link
Owner

sstur commented May 10, 2016

@beiciye: That question doesn't belong in this issue, the issue you're looking for is #6. It's still a work-in-progress.

@sstur
Copy link
Owner

sstur commented May 10, 2016

I updated the package.json to read:

  "peerDependencies": {
    "react": "^0.14.0 || ^15.0.1",
    "react-dom": "^0.14.0 || ^15.0.1"
  },

Closing this issue. Please re-open if that doesn't fix the issue. Thx.

@sstur sstur closed this as completed May 10, 2016
@vitosamson
Copy link

Thanks @sstur, could you cut a new version and publish it to npm?

@sstur
Copy link
Owner

sstur commented May 10, 2016

Done.

jlegrone added a commit to Bernie-2016/ground-control that referenced this issue Jun 9, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants