Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add ie11 paste support #50

Merged
merged 3 commits into from May 3, 2018

Conversation

Projects
None yet
2 participants
@webark
Copy link
Contributor

commented May 2, 2018

ie11 does not support the clipboardData on the paste event, but has a seprate window wide clipboard data that it uses.

Also, ie11 does not support the insertText option of document.execCommand so instead we fall back on a selection, textnode, range hack to insert that text into the element.

add ie11 paste support
ie11 does not support the clipboardData on the paste event, but has a seprate window wide clipboard data that it uses.
Also, ie11 does not support the  `insertText ` option of `document.execCommand` so instead we fall back on a selection, textnode, range hack to insert that text into the element.
@webark

This comment has been minimized.

Copy link
Contributor Author

commented May 2, 2018

@st-h let me know if there is anything else that you would like.

@webark

This comment has been minimized.

Copy link
Contributor Author

commented May 2, 2018

I can add a method to get that codeclimate complexity down.

webark added some commits May 2, 2018

Simplify methods.
Split off the insertText method to help with code complexity
@webark

This comment has been minimized.

Copy link
Contributor Author

commented May 2, 2018

@st-h fixed those codeclimate complexity issues.

@st-h

This comment has been minimized.

Copy link
Owner

commented May 3, 2018

@webark awesome! thanks for finding and fixing.

@st-h st-h merged commit 6efb554 into st-h:master May 3, 2018

2 checks passed

codeclimate All good!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@st-h

This comment has been minimized.

Copy link
Owner

commented May 3, 2018

released as 1.0.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.