Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IllegalArgumentException during js file generation #103

Closed
Tapsi opened this issue Aug 9, 2015 · 6 comments

Comments

@Tapsi
Copy link

commented Aug 9, 2015

Error:

[ERROR] C:\Users\xxx\Documents\CustomWarsTactics\cwtactics\gameSrc\org\wolftec\cwt\sheets\MoveType.java [1:1]: java.lang.IllegalArgumentException: Illegal character in path at index 3: org\wolftec\cwt\sheets\MoveType.js
java.lang.IllegalArgumentException: Illegal character in path at index 3: org\wolftec\cwt\sheets\MoveType.js
at java.net.URI.create(URI.java:852)
at java.net.URI.resolve(URI.java:1036)
at org.stjs.generator.Generator.getRuntimeUri(Generator.java:189)
at org.stjs.generator.Generator.generateJavascript(Generator.java:176)
...

Description: I get this error for every source file in my project. So no js files will be generated in the target directory.

Affected Versions: 3.2.0

Environment: Windows 10

My Assumption: The problem is may introduced due the commit https://github.com/st-js/st-js/commit/418df4777348abd0506174121508f70224a1e24f. The \ character in path of the source files produces the error because this character is may not escaped (which is required for an URI as mentioned in the RFC 2396).

@npiguet npiguet closed this in 1898ba9 Aug 19, 2015

@npiguet

This comment has been minimized.

Copy link
Member

commented Aug 19, 2015

Can you double check that the last commit fixes your issue? I couldn't find a way to write a proper automated test for that.

@npiguet npiguet reopened this Aug 19, 2015

@Tapsi

This comment has been minimized.

Copy link
Author

commented Aug 19, 2015

Reviewed the commit. That should work.

@npiguet

This comment has been minimized.

Copy link
Member

commented Aug 20, 2015

I guess we'll call it fixed then. Don't hesitate to re-open this if you encounter more problems.

@npiguet npiguet closed this Aug 20, 2015

@npiguet

This comment has been minimized.

Copy link
Member

commented Aug 20, 2015

FYI: I've release version 3.2.1, it should land in the maven central repositories in the next few minutes.

@Tapsi

This comment has been minimized.

Copy link
Author

commented Aug 20, 2015

Nice job! I'll test the bugfix on the mentioned environment today.

@Tapsi

This comment has been minimized.

Copy link
Author

commented Aug 20, 2015

Fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.