From 742292110e9feeccdeef2d589dde7705e928bd21 Mon Sep 17 00:00:00 2001 From: Markus Staab Date: Sun, 10 Jul 2022 12:47:20 +0200 Subject: [PATCH 1/2] Use new constants --- ...yntaxErrorInPreparedStatementMethodRuleReflectorTest.php | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/tests/rules/SyntaxErrorInPreparedStatementMethodRuleReflectorTest.php b/tests/rules/SyntaxErrorInPreparedStatementMethodRuleReflectorTest.php index 961755102..1d14c7f91 100644 --- a/tests/rules/SyntaxErrorInPreparedStatementMethodRuleReflectorTest.php +++ b/tests/rules/SyntaxErrorInPreparedStatementMethodRuleReflectorTest.php @@ -29,7 +29,7 @@ public function testSyntaxErrorInQueryRule(): void self::markTestSkipped('Test requires PHP 7.4.'); } - if ('mysqli' === getenv('DBA_REFLECTOR')) { + if (MysqliQueryReflector::NAME === getenv('DBA_REFLECTOR')) { $expectedErrors = [ [ "Query error: You have an error in your SQL syntax; check the manual that corresponds to your MySQL/MariaDB server version for the right syntax to use near 'freigabe1u1 FROM ada LIMIT 0' at line 1 (1064).", @@ -76,7 +76,7 @@ public function testSyntaxErrorInQueryRule(): void 319, ], ]; - } elseif ('pdo-pgsql' === getenv('DBA_REFLECTOR')) { + } elseif (PdoPgSqlQueryReflector::NAME === getenv('DBA_REFLECTOR')) { $expectedErrors = [ [ 'Query error: SQLSTATE[42601]: Syntax error: 7 ERROR: syntax error at or near "freigabe1u1" @@ -145,7 +145,7 @@ public function testSyntaxErrorInQueryRule(): void 319, ], ]; - } elseif ('pdo-mysql' === getenv('DBA_REFLECTOR')) { + } elseif (PdoMysqlQueryReflector::NAME === getenv('DBA_REFLECTOR')) { $expectedErrors = [ [ "Query error: SQLSTATE[42000]: Syntax error or access violation: 1064 You have an error in your SQL syntax; check the manual that corresponds to your MySQL/MariaDB server version for the right syntax to use near 'freigabe1u1 FROM ada LIMIT 0' at line 1 (42000).", From 4f4ea628eb6ba955f306399e5ba9b6c2ec12baaa Mon Sep 17 00:00:00 2001 From: Markus Staab Date: Sun, 10 Jul 2022 12:51:37 +0200 Subject: [PATCH 2/2] Update SyntaxErrorInPreparedStatementMethodRuleReflectorTest.php --- .../SyntaxErrorInPreparedStatementMethodRuleReflectorTest.php | 3 +++ 1 file changed, 3 insertions(+) diff --git a/tests/rules/SyntaxErrorInPreparedStatementMethodRuleReflectorTest.php b/tests/rules/SyntaxErrorInPreparedStatementMethodRuleReflectorTest.php index 1d14c7f91..024be0d3f 100644 --- a/tests/rules/SyntaxErrorInPreparedStatementMethodRuleReflectorTest.php +++ b/tests/rules/SyntaxErrorInPreparedStatementMethodRuleReflectorTest.php @@ -4,6 +4,9 @@ use PHPStan\Rules\Rule; use PHPStan\Testing\RuleTestCase; +use staabm\PHPStanDba\QueryReflection\MysqliQueryReflector; +use staabm\PHPStanDba\QueryReflection\PdoMysqlQueryReflector; +use staabm\PHPStanDba\QueryReflection\PdoPgSqlQueryReflector; use staabm\PHPStanDba\Rules\SyntaxErrorInPreparedStatementMethodRule; /**