Add STAC_API_VERSION in landing page

[m-mohr]

I'm a bit confused by

stac-fastapi/stac_fastapi/types/stac_fastapi/types/core.py

Line 271 in 3c4ce2e

stac_version: str = attr.ib(default=STAC_API_VERSION)

STAC_API_VERSION is meant to be the STAC API version (i.e. stac-api-spec), right?

But the STAC API Version is different to the STAC version. We try to expose STAC 1.1.0 items and update the landing page to 1.1.0, too, but setting the STAC_API_VERSION seems incorrect, because there is no 1.1.0 version for the API.

[vincentsarago]

yeah I think this got mixed up.

I think we should update this to STAC_VERSION and not STAC_API_VERION

https://github.com/stac-utils/stac-pydantic/blob/main/stac_pydantic/catalog.py#L17

[m-mohr]

Maybe it's also valuable to have STAC_API_VERSION if you want to switch between (bugfix) API versions, but having a separate STAC_VERSION is certainly a good idea. Do you think it makes sense to also have a STAC_API_VERSION? (e.g. to update to easily/quickly STAC API 1.0.1 once released?)

[vincentsarago]

the stac-api-specification only mention stat-version in the landing model

https://github.com/radiantearth/stac-api-spec/blob/bab9bdf22b54cd119e931859b0da13f42091abb8/core/commons.yaml#L50-L51

but extra values are allowed https://github.com/stac-utils/stac-pydantic/blob/main/stac_pydantic/catalog.py#L22

[vincentsarago]

I've created #762

adding stac_api_version is a bit more complication because it will involve more changes and a new Minor version so if we really want this we should create a specific issue for it

[m-mohr]

Not feeling strongly about STAC_API_VERSION, we can just fix the actual issue for now. Thanks for creating the PR!

[vincentsarago]

closing this for now because it's not a spec requirement