Update to STAC spec 1.0.0 #86
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moradology
force-pushed
the
feature/stac-spec-1.0.0
branch
from
bdf8d94
to
1826810
Compare
kylebarron
reviewed
Jun 9, 2021
|
Here's a list of the changes to the spec with those that triggered updates in pydantic modeling called out at the end of relevant lines ("noop" when no change applied to here, "changed" when a change has been applied, and a longer note in more complicated or questionable cases): v1.0.0 - 2021-05-25
|
|
This is ready to be reviewed/inspected for sense but work continues to get the tests functioning correctly. Currently the majority of the tests are failing with 404s as they request 1.0.0 compliant example JSON The lack of 1.0.0 examples makes this all a bit problematic and suggestions are very welcome. |
moradology
commented
Jun 15, 2021
| @@ -1 +1 @@ | |||
| STAC_VERSION = "1.0.0-beta.2" | |||
| STAC_VERSION = "1.0.0" | |||
There was a problem hiding this comment.
This change, if omitted, allows tests to complete successfully as the prior files all appear to be 1.0.0 compliant
There was a problem hiding this comment.
I'm rolling some example files that simply extend the previously working versions to use some 1.0.0 features. More canonical examples can be swapped in later if that's desirable
There was a problem hiding this comment.
And they are assembled here, temporarily: https://gist.github.com/moradology/977878279e1f36a6494877cdeaf18688
There was a problem hiding this comment.
I've gone ahead and folded the testing files within this repository
kylebarron
reviewed
Jun 17, 2021
| { | ||
| "stac_version": "1.0.0", | ||
| "stac_extensions": [ | ||
| "scientific", |
There was a problem hiding this comment.
The extension ids need to be fully qualified in 1.0.0 I think?
There was a problem hiding this comment.
You're absolutely right
There was a problem hiding this comment.
I'm going to fix this in the test files but I wonder if more validation isn't desirable in the model itself to avoid this kind of oversight
There was a problem hiding this comment.
It looks like JSON Schema now requires it to be an iri https://github.com/radiantearth/stac-spec/blob/789e90fba4c7119bc925d26f75f47bacf44c91e6/item-spec/json-schema/item.json#L105
So maybe use AnyUrl or similar? https://pydantic-docs.helpmanual.io/usage/types/#urls
geospatial-jeff
requested changes
Jun 25, 2021
Codecov Report
@@ Coverage Diff @@
## master #86 +/- ##
==========================================
- Coverage 98.33% 96.38% -1.96%
==========================================
Files 33 19 -14
Lines 779 442 -337
==========================================
- Hits 766 426 -340
- Misses 13 16 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
geospatial-jeff
approved these changes
Jun 25, 2021
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is aimed at updating models to correspond to updates in the STAC spec since 1.0.0-beta. Changes introduced here are based on the relevant updates to STAC-Spec listed here in rc1, rc2, rc3, rc4, and 1.0.0: https://github.com/radiantearth/stac-spec/blob/v1.0.0/CHANGELOG.md