add support for hidden collections parameter for applying auth #874
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tylanderson
approved these changes
Apr 7, 2025
Collaborator
tylanderson
left a comment
tylanderson
left a comment
There was a problem hiding this comment.
Tested and was able to confirm behavior working as expected. Only question here would be if this should be controlled through a param to allow deployments to enable / disable this behavior as it's non-standard
There was a problem hiding this comment.
Copilot reviewed 17 out of 18 changed files in this pull request and generated 1 comment.
Files not reviewed (1)
- package.json: Language not supported
Comments suppressed due to low confidence (1)
src/lib/api.js:517
- [nitpick] Consider clarifying or removing the 'TODO' comment to explicitly state the intended behavior for encoding the collections parameter in pagination links once finalized.
} else if (p === 'collections') { // TODO
| const { collectionId } = t.context | ||
|
|
||
| // disable collections filtering | ||
| process.env['ENABLE_COLLECTIONS_AUTHX'] = 'not true' |
There was a problem hiding this comment.
Using the string 'not true' to disable the collections filtering may be error-prone; consider using a clear boolean string ('true' to enable and 'false' to disable) or resetting the variable after the test to prevent side effects.
Suggested change
| process.env['ENABLE_COLLECTIONS_AUTHX'] = 'not true' | |
| process.env['ENABLE_COLLECTIONS_AUTHX'] = 'false' |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue(s):
Proposed Changes:
PR Checklist: