Skip to content

Conversation

@Maleware
Copy link
Member

@Maleware Maleware commented Nov 26, 2025

Description

During testing I found some leftovers in the docs. This is the fix to update DAG syntax to Airflow 3.

However, I'm not sure if we want Airflow 2 or Airflow 3 DAG syntax being present in our docs.

Author

  • Links to generated (nightly) docs added

Reviewer

  • Documentation added or updated. Follows the style guide.

Acceptance

  • Links to generated (nightly) docs added

@sbernauer sbernauer moved this to Development: Waiting for Review in Stackable Engineering Nov 26, 2025
Copy link
Member

@adwk67 adwk67 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - Thanks for catching that!

@Maleware Maleware added this pull request to the merge queue Nov 27, 2025
@Maleware
Copy link
Member Author

Maleware commented Nov 27, 2025

Thanks for approving. Do you think it's worth back porting it to 25.11?

Merged via the queue into main with commit 5cb26ea Nov 27, 2025
17 checks passed
@Maleware Maleware deleted the fix/docs-apply-spark-job branch November 27, 2025 08:23
@adwk67
Copy link
Member

adwk67 commented Nov 27, 2025

Thanks for approving. Do you think it's worth back porting it to 25.11?

I'd leave it as I don't think the examples don't specify an Airflow product version, and 25.11 still supports both 2.x and 3.x.

@adwk67 adwk67 moved this from Development: Waiting for Review to Development: In Review in Stackable Engineering Nov 27, 2025
@adwk67 adwk67 moved this from Development: In Review to Development: Done in Stackable Engineering Nov 28, 2025
@lfrancke lfrancke moved this from Development: Done to Done in Stackable Engineering Dec 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Development

Successfully merging this pull request may close these issues.

4 participants