Skip to content

[Merged by Bors] - Implement resource requests and limits for Druid pods #298

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 14 commits into from
Closed

[Merged by Bors] - Implement resource requests and limits for Druid pods #298

wants to merge 14 commits into from

Conversation

maltesander
Copy link
Member

Description

closes #277

Review Checklist

  • Code contains useful comments
  • CRD change approved (or not applicable)
  • (Integration-)Test cases added (or not applicable)
  • Documentation added (or not applicable)
  • Changelog updated (or not applicable)
  • Cargo.toml only contains references to git tags (not specific commits or branches)
  • Helm chart can be installed and deployed operator works (or not applicable)

Once the review is done, comment bors r+ (or bors merge) to merge. Further information

@maltesander maltesander requested a review from a team September 7, 2022 11:17
@maltesander maltesander self-assigned this Sep 7, 2022
@sbernauer sbernauer self-assigned this Sep 7, 2022
@maltesander
Copy link
Member Author

https://ci.stackable.tech/view/02%20Operator%20Tests%20(custom)/job/druid-operator-it-custom/12/

@maltesander maltesander marked this pull request as ready for review September 7, 2022 11:41
sbernauer
sbernauer reviewed Sep 7, 2022
View reviewed changes
maltesander and others added 4 commits September 7, 2022 13:58
@maltesander @sbernauer
Update CHANGELOG.md
70a2b52 
Co-authored-by: Sebastian Bernauer <sebastian.bernauer@stackable.de>
@maltesander @sbernauer
Update tests/templates/kuttl/resources/00-assert.yaml
ca03c53 
Co-authored-by: Sebastian Bernauer <sebastian.bernauer@stackable.de>
@maltesander
resources now tested only vs one (latest) zookeeper
10e0009
@maltesander
Merge remote-tracking branch 'origin/resource_limits' into resource_l…
5f2aec9 
…imits
sbernauer
sbernauer previously approved these changes Sep 7, 2022
View reviewed changes
Copy link
Member

@sbernauer sbernauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM % comment when tests succeed

@maltesander
Copy link
Member Author

https://ci.stackable.tech/view/02%20Operator%20Tests%20(custom)/job/druid-operator-it-custom/13/ another try (resources worked, two others failed)

sbernauer
sbernauer approved these changes Sep 8, 2022
View reviewed changes
Copy link
Member

@sbernauer sbernauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://ci.stackable.tech/view/02%20Operator%20Tests%20(custom)/job/druid-operator-it-custom/14/parameters/ succeeded

sbernauer
sbernauer approved these changes Sep 8, 2022
View reviewed changes
Copy link
Member

@sbernauer sbernauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice thanks!

@maltesander
Copy link
Member Author

bors merge

bors bot pushed a commit that referenced this pull request Sep 8, 2022
@maltesander
Implement resource requests and limits for Druid pods (#298)
4552503 
# Description

closes #277



Co-authored-by: Malte Sander <malte.sander.it@gmail.com>
@bors
Copy link
Contributor

bors bot commented Sep 8, 2022

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title Implement resource requests and limits for Druid pods [Merged by Bors] - Implement resource requests and limits for Druid pods Sep 8, 2022
@bors bors bot closed this Sep 8, 2022
@bors bors bot deleted the resource_limits branch September 8, 2022 13:20
@sbernauer sbernauer mentioned this pull request Oct 13, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbernauer sbernauer sbernauer approved these changes

Assignees

@maltesander maltesander

@sbernauer sbernauer

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement resource requests and limits for Druid pods
2 participants
@maltesander @sbernauer