Skip to content

[Merged by Bors] - Logging #294

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 22 commits into from
Closed

[Merged by Bors] - Logging #294

wants to merge 22 commits into from

Conversation

siegfriedweber
Copy link
Member

@siegfriedweber siegfriedweber commented Dec 21, 2022

Description

Add log aggregation

Closes #291

Integration Tests

Build Status

Review Checklist

  • Code contains useful comments
  • CRD change approved (or not applicable)
  • (Integration-)Test cases added (or not applicable)
  • Documentation added (or not applicable)
  • Changelog updated (or not applicable)
  • Cargo.toml only contains references to git tags (not specific commits or branches)
  • Helm chart can be installed and deployed operator works (or not applicable)

Once the review is done, comment bors r+ (or bors merge) to merge. Further information

@siegfriedweber siegfriedweber added release-note Denotes a PR that will be considered when it comes time to generate release notes. type/feature-new labels Dec 21, 2022
@siegfriedweber siegfriedweber self-assigned this Dec 21, 2022
@siegfriedweber siegfriedweber marked this pull request as ready for review December 21, 2022 15:13
@siegfriedweber siegfriedweber requested a review from a team December 21, 2022 15:14
@maltesander maltesander self-requested a review December 21, 2022 16:03
Copy link
Member

@maltesander maltesander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just nitpicking, LGTM overrall.
Running integration tests locally

Copy link
Member

@maltesander maltesander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@siegfriedweber
Copy link
Member Author

bors merge

bors bot pushed a commit that referenced this pull request Dec 22, 2022
# Description

Add log aggregation
@bors
Copy link
Contributor

bors bot commented Dec 22, 2022

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title Logging [Merged by Bors] - Logging Dec 22, 2022
@bors bors bot closed this Dec 22, 2022
@bors bors bot deleted the logging branch December 22, 2022 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release/23.1.0 release-note Denotes a PR that will be considered when it comes time to generate release notes. type/feature-new
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable log aggregation
3 participants