From 020a6935ef7488c91e306844d59ce5055849e6cf Mon Sep 17 00:00:00 2001 From: Sebastian Bernauer Date: Wed, 8 Nov 2023 10:01:23 +0100 Subject: [PATCH 1/2] fix: Removed field autoFormatFs, which was never read --- CHANGELOG.md | 1 + deploy/helm/hdfs-operator/crds/crds.yaml | 3 --- rust/crd/src/lib.rs | 2 -- 3 files changed, 1 insertion(+), 5 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index ab22f63d..c59b21e4 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -21,6 +21,7 @@ All notable changes to this project will be documented in this file. ### Fixed - Don't default roleGroup replicas to zero when not specified ([#402]). +- [BREAKING] Removed field `autoFormatFs`, which was never read ([#XXX]). ### Removed diff --git a/deploy/helm/hdfs-operator/crds/crds.yaml b/deploy/helm/hdfs-operator/crds/crds.yaml index 0c8745de..90e3f8fd 100644 --- a/deploy/helm/hdfs-operator/crds/crds.yaml +++ b/deploy/helm/hdfs-operator/crds/crds.yaml @@ -46,9 +46,6 @@ spec: required: - kerberos type: object - autoFormatFs: - nullable: true - type: boolean dfsReplication: default: 3 format: uint8 diff --git a/rust/crd/src/lib.rs b/rust/crd/src/lib.rs index 02dc7bf4..4324ba43 100644 --- a/rust/crd/src/lib.rs +++ b/rust/crd/src/lib.rs @@ -95,8 +95,6 @@ pub struct HdfsClusterSpec { #[derive(Clone, Debug, Deserialize, Eq, Hash, JsonSchema, PartialEq, Serialize)] #[serde(rename_all = "camelCase")] pub struct HdfsClusterConfig { - // FIXME: This attribute does not seem to be read anywhere. - pub auto_format_fs: Option, #[serde(default = "default_dfs_replication_factor")] pub dfs_replication: u8, /// Name of the Vector aggregator discovery ConfigMap. From b7f09f050b92da885756ec124963fe3b863e4bb0 Mon Sep 17 00:00:00 2001 From: Sebastian Bernauer Date: Wed, 8 Nov 2023 10:02:31 +0100 Subject: [PATCH 2/2] changelog --- CHANGELOG.md | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index c59b21e4..d251b691 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -21,7 +21,7 @@ All notable changes to this project will be documented in this file. ### Fixed - Don't default roleGroup replicas to zero when not specified ([#402]). -- [BREAKING] Removed field `autoFormatFs`, which was never read ([#XXX]). +- [BREAKING] Removed field `autoFormatFs`, which was never read ([#422]). ### Removed @@ -37,6 +37,7 @@ All notable changes to this project will be documented in this file. [#405]: https://github.com/stackabletech/hdfs-operator/pull/405 [#407]: https://github.com/stackabletech/hdfs-operator/pull/407 [#409]: https://github.com/stackabletech/hdfs-operator/pull/409 +[#422]: https://github.com/stackabletech/hdfs-operator/pull/422 ## [23.7.0] - 2023-07-14