Repository navigation
fix: allow fine-granular resource CPU settings - #408
Conversation
|
Jenkins: |
sbernauer
left a comment
There was a problem hiding this comment.
This is exactly what I was thinking of, awesome!
Change LGTM, I'm currently thinking if we can improve any tests around this 🤔 At least we already have the resources kuttl test :)
Co-authored-by: Sebastian Bernauer <sebastian.bernauer@stackable.de>
|
We might want to mark it as breaking in the changelog: BREAKING: Specified CPU resources are now applied correctly (instead of rounding it to the next whole number). This might affect your jobs, as they now e.g. only have 200m CPU resources available instead of the 1000m it had so far and they might slow down significantly |
|
Yes, good point. Have added note to changelog. |
Co-authored-by: Sebastian Bernauer <sebastian.bernauer@stackable.de>
Description
fixes #363.
Definition of Done Checklist