Skip to content

Build binaries for Linux and MacOS#93

Merged
sbernauer merged 14 commits into
stackabletech:mainfrom
sbernauer:main
Aug 16, 2023
Merged

Build binaries for Linux and MacOS#93
sbernauer merged 14 commits into
stackabletech:mainfrom
sbernauer:main

Conversation

@sbernauer

@sbernauer sbernauer commented Aug 11, 2023

Copy link
Copy Markdown
Member

Description

Windows build is currently broken.
Release workflow can be added trivially later on

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes
# Author
- [ ] Changes are OpenShift compatible
- [ ] CRD changes approved
- [ ] Helm chart can be installed and deployed operator works
- [ ] Integration tests passed (for non trivial changes)
# Reviewer
- [ ] Code contains useful comments
- [ ] (Integration-)Test cases added
- [ ] Documentation added or updated
- [ ] Changelog updated
- [ ] Cargo.toml only contains references to git tags (not specific commits or branches)
# Acceptance
- [ ] Feature Tracker has been updated
- [ ] Proper release label has been added

Once the review is done, comment bors r+ (or bors merge) to merge. Further information

Comment thread .github/workflows/build.yml Outdated
Comment thread .github/workflows/build.yml
@sbernauer sbernauer self-assigned this Aug 14, 2023
@sbernauer sbernauer requested a review from Techassi August 14, 2023 08:46
Techassi
Techassi previously approved these changes Aug 15, 2023

@Techassi Techassi left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but let's wait for stackabletech/operator-rs#635 to be merged, so that we can comment out the patch in the Cargo.toml file.

@sbernauer

Copy link
Copy Markdown
Member Author

@Techassi switched to main branch, please have a look!

@sbernauer sbernauer enabled auto-merge August 15, 2023 08:10
@Techassi

Copy link
Copy Markdown
Member

This should work for now, but we might want to bump operator-rs to 0.46.1.

@sbernauer

Copy link
Copy Markdown
Member Author

Given the amount of PRs we have (and probably) will open for operator-rs I would prefer to not release it too often (currently we already pin a specific operator-rs commit in main) "only" for the cockpit.
Lets ask in the daily if there are objections against a release

@Techassi

Copy link
Copy Markdown
Member

We now confirmed a new operator-rs release. Let's wait for it, update the dependency and then this PR will be ready.

@sbernauer

Copy link
Copy Markdown
Member Author

@Techassi bumped to 0.47.0

Comment thread Cargo.toml Outdated
Techassi
Techassi previously approved these changes Aug 16, 2023
Comment thread .github/workflows/build.yml
@sbernauer sbernauer added this pull request to the merge queue Aug 16, 2023
@Techassi Techassi removed this pull request from the merge queue due to a manual request Aug 16, 2023
@Techassi Techassi added this pull request to the merge queue Aug 16, 2023
@Techassi Techassi removed this pull request from the merge queue due to a manual request Aug 16, 2023
@sbernauer

Copy link
Copy Markdown
Member Author

@Techassi sorry dismissed your review. Ready to be approved and merged now

@sbernauer sbernauer added this pull request to the merge queue Aug 16, 2023
@sbernauer

Copy link
Copy Markdown
Member Author

Thanks for the review!

@sbernauer

Copy link
Copy Markdown
Member Author

Finally a green pipeline, yeah!

Merged via the queue into stackabletech:main with commit 1294dff Aug 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants