Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - Tls authentication and encryption #479

Closed
wants to merge 28 commits into from

Conversation

maltesander
Copy link
Member

@maltesander maltesander commented May 6, 2022

Description

closes #466

Currently there is still a workaround (TLS can be used via the clientPort and not secureClientPort with port unification. This means there still can be plaintext connections without encryption or authentication; see https://issues.apache.org/jira/browse/ZOOKEEPER-4276)

Review Checklist

  • Code contains useful comments
  • (Integration-)Test cases added (or not applicable)
  • Documentation added (or not applicable)
  • Changelog updated (or not applicable)
  • Cargo.toml only contains references to git tags (not specific commits or branches)
  • Helm chart can be installed and deployed operator works (or not applicable)

Once the review is done, comment bors r+ (or bors merge) to merge. Further information

@maltesander maltesander requested a review from a team May 9, 2022 13:25
@maltesander maltesander marked this pull request as ready for review May 9, 2022 13:25
maltesander and others added 3 commits May 9, 2022 15:27
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@adwk67 adwk67 self-assigned this May 11, 2022
@adwk67 adwk67 self-requested a review May 11, 2022 07:49
maltesander and others added 2 commits May 11, 2022 13:04
Co-authored-by: Sebastian Bernauer <sebastian.bernauer@stackable.de>
@maltesander maltesander requested review from adwk67 and sbernauer May 11, 2022 11:30
Copy link
Member

@adwk67 adwk67 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@maltesander
Copy link
Member Author

bors merge

bors bot pushed a commit that referenced this pull request May 11, 2022
## Description

closes #466

Currently there is still a workaround (TLS can be used via the `clientPort` and not `secureClientPort` with port unification. This means there still can be plaintext connections without encryption or authentication; see https://issues.apache.org/jira/browse/ZOOKEEPER-4276)



Co-authored-by: Malte Sander <malte.sander.it@gmail.com>
@bors
Copy link
Contributor

bors bot commented May 11, 2022

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title Tls authentication and encryption [Merged by Bors] - Tls authentication and encryption May 11, 2022
@bors bors bot closed this May 11, 2022
@bors bors bot deleted the tls_authentication_and_encryption branch May 11, 2022 15:06
@maltesander maltesander mentioned this pull request Jul 12, 2022
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TLS authentication & encryption
3 participants