Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable SN in Breez (with WebLN) #46

Closed
notnout opened this issue Sep 28, 2021 · 5 comments
Closed

Enable SN in Breez (with WebLN) #46

notnout opened this issue Sep 28, 2021 · 5 comments
Labels
feature new product features that weren't there before

Comments

@notnout
Copy link
Contributor

notnout commented Sep 28, 2021

WebLN is a pre-requisite for the app to be included in Breez and other lightning apps.

The implementation can be fairly simple, https://webln.dev/#/ and when ready worth pinging some of the teams like Breez to include SN there.
This would be both useful and also good marketing ;)

@huumn
Copy link
Member

huumn commented Sep 28, 2021

We already have support for it on invoice/withdrawal. #35 Is there some functionality I'm missing?

@notnout
Copy link
Contributor Author

notnout commented Sep 28, 2021

Then I guess the main missing point is sending PR to Breez to enable it there? :)

@notnout notnout changed the title Add support for WebLN Enable SN in Breez (with WebLN) Sep 28, 2021
@huumn
Copy link
Member

huumn commented Oct 27, 2021

Submitted relevant assets to Breez. Waiting for ball to come back to my court.

@huumn
Copy link
Member

huumn commented Nov 10, 2021

The current blocker is implementing this https://github.com/breez/breezmobile/wiki/Adding-a-WebLN-widget-with-LNURL-Auth ... unfortunately it requires me to implement a novel auth flow just for Breez .

(I wish they'd save credentials by just stashing browser cookies - it'd allow web apps to onboard without having to do anything new with regard to auth regardless of the way the app auths users because they likely all use cookies anyway.)

@huumn
Copy link
Member

huumn commented Nov 11, 2021

Note to self: To get this to work I'll have to create a server-side version of this function and then inspect the resulting cookies to grab the jwt https://github.com/nextauthjs/next-auth/blob/78fa33312f4d64b74e01ee479ba4faedf3980f71/src/client/index.js#L177-L238

More on this: Given we aren't being called from a client browser, I'll also probably need to make another request to get a csrf token and then make the above request with the token. This is outlined here nextauthjs/next-auth#1627.

@ekzyis ekzyis added the feature new product features that weren't there before label May 19, 2023
@huumn huumn closed this as not planned Won't fix, can't repro, duplicate, stale Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature new product features that weren't there before
Projects
None yet
Development

No branches or pull requests

3 participants