Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

.s-inputs are rendering with the default OS font #29

Closed
aaronshekey opened this issue Jun 8, 2018 · 0 comments
Closed

.s-inputs are rendering with the default OS font #29

aaronshekey opened this issue Jun 8, 2018 · 0 comments
Labels
bug A reproducible problem with the Stacks code

Comments

@aaronshekey
Copy link
Contributor

As observed on the Teams join workflow, it appears that inputs with s-input applied are inheriting the OS-level fonts, and not ff-sans as intended. I think we need to add our standard fonts to s-inputs, text areas, etc.

screen shot 2018-06-08 at 12 54 23 am

Sadly, San Francisco looks soooo good here, but it's not intended in this case.
@aaronshekey aaronshekey added the bug A reproducible problem with the Stacks code label Jun 8, 2018
hellohynes added a commit that referenced this issue Jun 8, 2018
@hellohynes
Decrease input padding and increase line-height so descenders aren't …
a387e92 
…clipped. Inherit font-family instead of using default font-family. Closes #29 and #30.
@hellohynes hellohynes mentioned this issue Jun 8, 2018
Merged
hellohynes added a commit that referenced this issue Jun 8, 2018
@hellohynes
Merge pull request #31 from StackExchange/input-bugs
548e4a3 
Fixes various s-input bugs. Closes #29 #30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug A reproducible problem with the Stacks code
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@aaronshekey @hellohynes