Get users and groups from distinct API requests #54
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m-bull
force-pushed
the
fix/user-group-pagination
branch
from
3dafe64 to
2a333be
Compare
m-bull
force-pushed
the
fix/user-group-pagination
branch
from
2a333be to
6d92efc
Compare
markgoddard
reviewed
Dec 5, 2022
m-bull
force-pushed
the
fix/user-group-pagination
branch
from
6d92efc to
190167a
Compare
markgoddard
reviewed
Dec 5, 2022
markgoddard
previously approved these changes
Dec 5, 2022
An API request to retrieve a list of all users and groups is subject to pagination, which can break assumptions if your object exists but is not returned in the first page results. Query each user and group from the API directly, and then parse the result to distinguish between objects that are present or absent.
m-bull
force-pushed
the
fix/user-group-pagination
branch
from
190167a to
1ce56d3
Compare
markgoddard
approved these changes
Dec 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An API request to retrieve a list of all users and groups is subject to pagination, which can break assumptions if your object exists but is not returned in the first page results.
Query each user and group from the API directly, and then parse the result to distinguish between objects that are present or absent.