Synchronise xena with upstream #35
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In multinode, the devstack plugin for networking-generic-switch can't really work as intended. But, the authorized keys is copied on all nodes, and zuul puts a consistent key in place, so it doesn't really need to do what it is doing, but we need to use the stack user's pre-existing keys to access the remote host. This will allow Ironic's multinode grenade job to work without errors about accessing the key file, which is a red herring for when the connection fails. Additionally, the underlying ngs code is suseptible to a race on configuration loading as configuration is loaded separately. We can't really force it to load the option. We also can't explicitly add it, so the best thing to do is to wrap it and rely upon a mock to facilitate the unit test. Change-Id: Ia8550c124f2ef1cce620a4fb28c35700d34aa027 (cherry picked from commit c6c10a1)
github-actions
bot
added
automated
markgoddard
approved these changes
Jun 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains a snapshot of xena from upstream.