Zed backports #61
Merged
Zed backports #61
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With this patch ngs starts supporting attaching of trunk port to baremetal server. Only VLAN Neutron network is supported. There are two ways to configure trunk port: * C1: When segmentation details for trunk ports are inherited from Neutron network. VLAN translation support is not required. Added implementation for cisco, arista, OVS on Linux. * C2: When user set segmentation details for trunk port explicitly. Switch should support VLAN translation for this case. Implement only for OVS on Linux, experimental. NetmikoSwitch.plug_port_to_network() is deprecated. New bind_port() should be used instead. New switch config option: vlan_translation_supported was introduced. This option defines if switch support vlan translation which affect the way how trunk is configured. Change-Id: If084382f4c17438e5142f51f88d6e436f8b85082 (cherry picked from commit 1163a1f) (cherry picked from commit 7dfe3e2) (cherry picked from commit c54e9ba)
Change-Id: Ia8b2e2b8ea90830fbdbc60d8a3b64afe693224db (cherry picked from commit 9ad464f)
This adds a new driver for Dell OS10 based switches. Original change by msherman64[1]. [1] ChameleonCloud#14 Change-Id: Ib5bba3067352e6c7e12120982fcf5b206c9dd365 (cherry picked from commit 0ecd02a)
Change-Id: I5d2f098d7633a23d60ae85d8b1e4cffb43182b4e (cherry picked from commit 56735ab)
Change-Id: I46684ae1cdd8207833172e5ee04aa865eb965931 (cherry picked from commit 8aafe00)
When you have around 60 baremetal nodes attached to a single switch, it takes a long time to execute all those commands. This gets worse when you limit the number of concurrent ssh connections. Here we look to batch up commands to send to the switch together using a single connection. The results of each port's commands are returned when available. This is implemented using etcd as a queueing system. Commands are added to an input key, then a worker thread processes the available commands for a particular switch device. We pull off the queue using the version at which the keys were added, giving a FIFO style queue. The result of each command set are added to an output key, which the original request thread is watching. Distributed locks are used to serialise the processing of commands for each switch device. Various neat etcd features are used here to alleviate some of the issues of distributed task coordination, including transactions, leases, watches, historical key/value tracking, etc. Co-Authored-By: Mark Goddard <mark@stackhpc.com> Change-Id: I8c458bbc94df5630cfede5434bcdbe527988059c (cherry picked from commit 45b237b)
The api_path was only added to the client helper function in etcd3gw 2.1.0. This is available in upper constraints for Zed. Change-Id: Ide34499f64f8e8a92be80a132ece6090701733a9 (cherry picked from commit 871e8bb)
markgoddard
suggested changes
Jul 17, 2023
markgoddard
left a comment
markgoddard
left a comment
There was a problem hiding this comment.
Compared with stackhpc/yoga and stable/zed. Mostly looks fine.
markgoddard
approved these changes
Jul 17, 2023
Alex-Welsh
force-pushed
the
zed-backports
branch
from
b697b3e to
deb3bc7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry picks: