Fix systemd unit file #3
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM, awaiting commit to bump rpm release. |
m-bull
force-pushed
the
fix/systemd-unit
branch
3 times, most recently
from
005c789 to
b71565b
Compare
m-bull
force-pushed
the
fix/systemd-unit
branch
from
b71565b to
f6cab31
Compare
|
Tested in https://github.com/m-bull/prometheus-slurm-exporter. Releases create and release versions increment on subsequent workflow runs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes for #2.
slurm_exporteruser and configure systemd unit to run as that user--listen-address=0.0.0.0:9341to the invocation ofslurm_exporterin systemdThink these are sensible defaults - deployment Ansible can always re-write the unit file and create users if needed.