From 82508be86f2cc520a388b6be17fba519dac3bd66 Mon Sep 17 00:00:00 2001 From: Matt Crees Date: Thu, 4 Sep 2025 14:37:19 +0000 Subject: [PATCH] Add error handling on lookup of user info Without this, the exporter would hang after raising the error: ``` File "radosgw_usage_exporter.py", line 465, in _get_user_info if "display_name" in user_info: ^^^^^^^^^^^^^^^^^^^^^^^^^^^ TypeError: argument of type 'NoneType' is not iterable ``` --- radosgw_usage_exporter.py | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/radosgw_usage_exporter.py b/radosgw_usage_exporter.py index 7885d18..f1498a8 100644 --- a/radosgw_usage_exporter.py +++ b/radosgw_usage_exporter.py @@ -462,6 +462,11 @@ def _get_user_info(self, user): ) logging.debug((json.dumps(user_info, indent=4, sort_keys=True))) + if user_info is None: + logging.warning(f"Failed to get info for user: {user}. " + "Metrics for this user will not be added.") + return + if "display_name" in user_info: user_display_name = user_info["display_name"] else: