Hook race fix #21
Merged
Hook race fix #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sjpb
requested changes
Aug 8, 2023
|
Made scontrol changes, only thing is that by using NodeName=all the other named nodes (i.e slurmd-[2-9]) will get added to the list in a drain state, but I'm guessing this wouldn't really be an issue in production? |
|
Actually one thing that I've realised is that this fix introduces a NEW race condition where once the nodes are undrained, jobs could potentially get scheduled onto them before the upgrade starts, I need to move the undraining to a post-upgrade hook |
sjpb
approved these changes
Aug 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The pre-upgrade hook will now drain all nodes before checking if jobs are running on them in order to prevent a race conditions in which pending jobs are scheduled onto the nodes after the check if complete. Will RESUME nodes on a successful upgrade