[doca] fix check/diff in install playbook #1995
Conversation
Signed-off-by: Bartosz Bezak <bartosz@stackhpc.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request correctly fixes an issue when running the install-doca.yml playbook in check mode by adding check_mode: false to the task that retrieves the kernel version. This ensures that the kernel variable is registered even during a dry run. I have added one suggestion to further improve the task's idempotency reporting.
| ansible.builtin.command: | ||
| cmd: "uname -r" | ||
| register: kernel | ||
| check_mode: false |
There was a problem hiding this comment.
While check_mode: false correctly ensures this task runs during a dry run, the command module reports a change on every execution by default. Since this task only retrieves information and doesn't alter the system state, it's good practice to also add changed_when: false. This will make the playbook's output clearer by not reporting a change for this read-only operation, improving idempotency reporting.
ansible.builtin.command:
cmd: "uname -r"
register: kernel
check_mode: false
changed_when: false
No description provided.