Skip to content

[doca] fix check/diff in install playbook #1995

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 24, 2025
+1 −0
Merged

[doca] fix check/diff in install playbook #1995

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions etc/kayobe/ansible/tools/install-doca.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
ansible.builtin.command:
cmd: "uname -r"
register: kernel
check_mode: false
Comment on lines 8 to +11
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot Nov 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

While check_mode: false correctly ensures this task runs during a dry run, the command module reports a change on every execution by default. Since this task only retrieves information and doesn't alter the system state, it's good practice to also add changed_when: false. This will make the playbook's output clearer by not reporting a change for this read-only operation, improving idempotency reporting.

      ansible.builtin.command:
        cmd: "uname -r"
      register: kernel
      check_mode: false
      changed_when: false


- name: Install kernel repo
ansible.builtin.dnf:
Expand Down
Loading