Fix docker image ls output - 2024.1 backport #2003
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Alex-Welsh
force-pushed
the
image-build-fix-backport
branch
from
b6a814f to
bc62fe7
Compare
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request fixes an issue with parsing the output of docker image ls by using the --format option, which is a great improvement for robustness. My review includes a suggestion to further improve this section by fixing a quoting issue and making the code more efficient by avoiding an unnecessary file read operation.
Alex-Welsh
force-pushed
the
image-build-fix-backport
branch
from
bc62fe7 to
4f47c55
Compare
Member
Author
Member
Author
RabbitMQ image build failed due to unrelated errors, but the scan script worked |
dougszumski
approved these changes
Nov 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Same issue as #2000 similar fix, but the scanning script was refactored in 2025.1
Test in progress https://github.com/stackhpc/stackhpc-kayobe-config/actions/runs/19732940444