Skip to content

Conversation

@MoteHue
Copy link
Contributor

@MoteHue MoteHue commented Dec 1, 2025

No description provided.

@MoteHue MoteHue requested a review from a team as a code owner December 1, 2025 15:29
@MoteHue MoteHue changed the base branch from stackhpc/2025.1 to stackhpc/2024.1 December 1, 2025 15:29
@MoteHue MoteHue added documentation Improvements or additions to documentation xs Extra small (Less than 10 changes) size: xs labels Dec 1, 2025
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a wide range of updates, including documentation improvements, dependency bumps, and significant feature enhancements like multi-arch support and a refactoring of secret store deployment playbooks. The changes are well-supported by corresponding release notes. The code quality is generally high, with good improvements in scripting and configuration flexibility. I have one suggestion regarding a hardcoded value in a Prometheus rule which could impact deployments with a different number of RabbitMQ nodes.

@Alex-Welsh
Copy link
Member

Check pipeline is sad. Can you try a squash and rebase?

Correct playbook run command in GPU docs

Fix code-block in Bifrost docs
@Alex-Welsh Alex-Welsh merged commit fbdb35d into stackhpc/2024.1 Dec 1, 2025
23 checks passed
@Alex-Welsh Alex-Welsh deleted the 2024.1-docs-fix-formatting branch December 1, 2025 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation size: xs xs Extra small (Less than 10 changes)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants