From 02301f4f8420a33c0cf7e25c2a5ad3ee4c488988 Mon Sep 17 00:00:00 2001
From: Dawud M <7688823+technowhizz@users.noreply.github.com>
Date: Fri, 23 Dec 2022 10:14:38 +0000
Subject: [PATCH 1/2] Fix missing group in smart alerting rules

---
 etc/kayobe/kolla/config/prometheus/smart.rules | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/etc/kayobe/kolla/config/prometheus/smart.rules b/etc/kayobe/kolla/config/prometheus/smart.rules
index 0b6552598f..aea36bdf8e 100644
--- a/etc/kayobe/kolla/config/prometheus/smart.rules
+++ b/etc/kayobe/kolla/config/prometheus/smart.rules
@@ -1,6 +1,10 @@
 {% raw %}
 
-- alert: DiskSmartStatusUnhealthy
+groups:
+- name: Smart
+  rules:
+
+  - alert: DiskSmartStatusUnhealthy
     expr: smartmon_device_smart_healthy < 1
     for: 10m
     labels:
@@ -9,4 +13,4 @@
       summary: "SMART monitor reports bad disk on (instance {{ $labels.instance }})"
       description: "{{ $labels.instance }} is reporting unhealthy for the disk at {{ $labels.disk }}. Disk serial number is: {{ $labels.serial_number }}"
 
-{% endraw %}
+{% endraw %}
\ No newline at end of file

From 5e237eb2c525558db67f6e22914bdd2c302b9a84 Mon Sep 17 00:00:00 2001
From: Dawud M <7688823+technowhizz@users.noreply.github.com>
Date: Fri, 23 Dec 2022 12:05:35 +0000
Subject: [PATCH 2/2] Add release note for smart rules bugfix

---
 releasenotes/notes/bugfix-smart-rules-53ff5400e7f681c8.yaml | 6 ++++++
 1 file changed, 6 insertions(+)
 create mode 100644 releasenotes/notes/bugfix-smart-rules-53ff5400e7f681c8.yaml

diff --git a/releasenotes/notes/bugfix-smart-rules-53ff5400e7f681c8.yaml b/releasenotes/notes/bugfix-smart-rules-53ff5400e7f681c8.yaml
new file mode 100644
index 0000000000..8da7f80fc0
--- /dev/null
+++ b/releasenotes/notes/bugfix-smart-rules-53ff5400e7f681c8.yaml
@@ -0,0 +1,6 @@
+---
+
+fixes:
+  - |
+    Fixed a syntax error in Prometheus SMART monitoring rules
+