-
Notifications
You must be signed in to change notification settings - Fork 29
fix(alb): print valid JSON/YAML output for list cmds #1045
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
This PR was marked as stale after 7 days of inactivity and will be closed after another 7 days of further inactivity. If this PR should be kept open, just add a comment, remove the stale label or push new commits to it. |
f44493d to
102b585
Compare
|
This PR was marked as stale after 7 days of inactivity and will be closed after another 7 days of further inactivity. If this PR should be kept open, just add a comment, remove the stale label or push new commits to it. |
|
This PR was marked as stale after 7 days of inactivity and will be closed after another 7 days of further inactivity. If this PR should be kept open, just add a comment, remove the stale label or push new commits to it. |
102b585 to
7a02a24
Compare
relates to STACKITCLI-273 / #893
7a02a24 to
4ea4bda
Compare
Merging this branch changes the coverage (2 decrease, 1 increase)
Coverage by fileChanged files (no unit tests)
Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code. Changed unit test files
|
relates to STACKITCLI-273 / #893
Description
relates to STACKITCLI-273 / #893
Testing
stackit beta alb list-> Expected output:No load balancers found for project "dev-tools-e2e-test"stackit beta alb list --output-format json-> expected valid JSON outputstackit beta alb list --output-format YAML-> expected valid YAML outputstackit beta alb observability-credentials list-> Expected output:no credentials foundstackit beta alb observability-credentials list --output-format json-> expected valid JSON outputstackit beta alb observability-credentials list --output-format yaml-> expected valid YAML outputstackit beta alb observability-credentials add --displayname "abc" --username "abc" --password "abc"stackit beta alb observability-credentials list-> Expected output: Table showing the available credentialsstackit beta alb observability-credentials list --output-format json-> expected valid JSON outputstackit beta alb observability-credentials list --output-format yaml-> expected valid YAML outputstackit beta alb plans-> Expected output: Table showing the available plansstackit beta alb plans --output-format json-> expected valid JSON outputstackit beta alb plans --output-format YAML-> expected valid YAML outputstackit beta alb observability-credentials delete credentials-xxxxChecklist
make fmtmake generate-docs(will be checked by CI)make test(will be checked by CI)make lint(will be checked by CI)