Skip to content

Conversation

@marceljk
Copy link
Contributor

@marceljk marceljk commented Nov 28, 2025

Description

relates to #1125

Testing instructions

  1. Checkout the branch of this PR and run $ make build
  2. Set the session limit to 1s, to simulate an expired session
    $ ./bin/stackit config set --session-time-limit 1s
  3. Authenticate with your user account
    $ ./bin/stackit auth login
  4. Run a command with output format json, e.g.:
    $ ./bin/stackit network list -o json | jq
    -> should work
  5. Checkout the main branch and rerun the previous command
    $ ./bin/stackit network list -o json | jq
    -> should fail

Checklist

  • Issue was linked above
  • Code format was applied: make fmt
  • Examples were added / adjusted (see e.g. here)
  • Docs are up-to-date: make generate-docs (will be checked by CI)
  • Unit tests got implemented or updated
  • Unit tests are passing: make test (will be checked by CI)
  • No linter issues: make lint (will be checked by CI)

@marceljk marceljk requested a review from a team as a code owner November 28, 2025 15:49
Copy link
Contributor

@cgoetz-inovex cgoetz-inovex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, manual test successfull

@marceljk marceljk force-pushed the fix/logging-browser-auth-url branch from 0e74f2a to 6f9d56c Compare November 28, 2025 16:13
@marceljk marceljk enabled auto-merge (squash) November 28, 2025 16:13
@marceljk marceljk merged commit 58a4b77 into main Nov 28, 2025
5 checks passed
@marceljk marceljk deleted the fix/logging-browser-auth-url branch November 28, 2025 16:19
@github-actions
Copy link

Merging this branch will not change overall coverage

Impacted Packages Coverage Δ 🤖
github.com/stackitcloud/stackit-cli/internal/pkg/auth 56.52% (ø)

Coverage by file

Changed files (no unit tests)

Changed File Coverage Δ Total Covered Missed 🤖
github.com/stackitcloud/stackit-cli/internal/pkg/auth/user_login.go 9.89% (ø) 182 18 164

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants