MCPRegistry sync policy

[dmartinol]

Fixes #1743

• Implemented Automatic and Manual sync policies
• Refactored controller code to extract business logic in separate handlers

Automatic trigger accepts only the interval parameter for now, no retry policies:

  syncPolicy:
    interval: 1m

It is defined using Go duration format. Examples: "1h", "30m", "24h"

Manual annotation works with trigger annotations like:

kubectl annotate mcpregistry auto-sync-registry \                                
    toolhive.stacklok.dev/sync-trigger=NEW_VALUE --overwrite

Sync status is defined in the status secrtion:

  lastManualSyncTrigger: "6"
  lastSyncHash: b67513010ff3fbf6d0b36c9df3bb4ee54f237673a872356488652c849010a1b6
  lastSyncTime: "2025-09-15T08:15:23Z"

[codecov]

Codecov Report

❌ Patch coverage is 57.31707% with 140 lines in your changes missing coverage. Please review.
✅ Project coverage is 46.45%. Comparing base (a39b1c8) to head (f4a2011).
⚠️ Report is 2 commits behind head on main.

Files with missing lines	Patch %	Lines
...thv-operator/controllers/mcpregistry_controller.go	0.00%	75 Missing ⚠️
cmd/thv-operator/pkg/sync/manager.go	67.20%	49 Missing and 12 partials ⚠️
cmd/thv-operator/pkg/sync/detectors.go	94.00%	2 Missing and 1 partial ⚠️
cmd/thv-operator/pkg/sources/storage_manager.go	93.33%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1886      +/-   ##
==========================================
+ Coverage   45.80%   46.45%   +0.64%     
==========================================
  Files         203      206       +3     
  Lines       25979    26145     +166     
==========================================
+ Hits        11900    12145     +245     
+ Misses      13167    13075      -92     
- Partials      912      925      +13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[jhrozek]

I left two nits that are OK to be fixed in a later PR

[Copilot]

Pull Request Overview

This PR implements automatic and manual sync policies for MCPRegistry resources, addressing issue #1743. The implementation introduces a clean separation of concerns by extracting sync logic from the controller into dedicated interfaces and handlers.

• Automatic sync supports interval-based triggering with configurable Go duration format (e.g., "1h", "30m", "24h")
• Manual sync is triggered via toolhive.stacklok.dev/sync-trigger annotation with value tracking to prevent duplicate syncs
• Comprehensive refactoring extracts business logic into separate sync package with proper interfaces and implementations

Reviewed Changes

Copilot reviewed 15 out of 15 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
docs/operator/crd-api.md	Adds documentation for new lastManualSyncTrigger status field
deploy/charts/operator-crds/templates/toolhive.stacklok.dev_mcpregistries.yaml	Updates CRD schema to include lastManualSyncTrigger field
deploy/charts/operator-crds/README.md	Bumps chart version to 0.0.25
deploy/charts/operator-crds/Chart.yaml	Updates chart version to 0.0.25
cmd/thv-operator/pkg/sync/	New sync package with interfaces and implementations for sync management
cmd/thv-operator/pkg/sources/storage_manager.go	Improves error handling and storage manager implementation
cmd/thv-operator/controllers/mcpregistry_controller.go	Refactored to use new sync manager interface
cmd/thv-operator/api/v1alpha1/mcpregistry_types.go	Adds lastManualSyncTrigger field to status

---

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

[jhrozek]

@dmartinol if you end up pushing a new version then getting rid of the commented out code might be good as well

[coveralls]

coverage: 43.639% (+0.6%) from 43.054%
when pulling f4a2011 on dmartinol:registry_sync
into a39b1c8 on stacklok:main.