-
Notifications
You must be signed in to change notification settings - Fork 155
Add thv group run command with full container and remote server support #1912
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: lujunsan <luisjuncaldev@gmail.com>
|
@rdimitrov @eleftherias this ended up being more complex than I had anticipated, would appreciate a thorough review! Happy to change the approach if something seems out of place. I've manually tested this extensively locally, but would also appreciate a bit of testing if possible! |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #1912 +/- ##
==========================================
+ Coverage 46.78% 46.96% +0.18%
==========================================
Files 220 220
Lines 27384 27483 +99
==========================================
+ Hits 12811 12907 +96
+ Misses 13591 13584 -7
- Partials 982 992 +10 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
yrobla
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
approving, i do not like the nolint, but it's something to be refactored as you said
eleftherias
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't done manual testing yet, but I have some thoughts on the structure. I'd lean towards having a more clearly separate path for running a group even if it involves some duplication. This is just a matter of preference so feel free to disagree and ignore the comments.
Signed-off-by: lujunsan <luisjuncaldev@gmail.com>
Signed-off-by: lujunsan <luisjuncaldev@gmail.com>
Signed-off-by: lujunsan <luisjuncaldev@gmail.com>
Summary
thv group run <group-name>command that deploys all MCP servers from a registry groupthv runcommands when possibleNew Command:
thv group runThe new command allows deploying entire groups of MCP servers with a single command:
Basic usage - deploy all servers in a group
With secrets and environment variables
Key Features
--secret VAR,target=server.TARGET_VARand--env server.VAR=value syntax to specify per-server configurationArchitecture Changes
Testing Examples
Test basic group deployment
thv group run simple-test
Test with targeted secrets
thv group run simple-test --secret GITHUB_TOKEN,target=github.GITHUB_PERSONAL_ACCESS_TOKEN
Test with environment variables
thv group run simple-test --env fetch.DEBUG=true --env github.LOG_LEVEL=info