Add ginkgolinter to golangci-lint configuration #1956
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds the ginkgolinter to our golangci-lint configuration to ensure better code quality and consistency in our Ginkgo test suites.
Changes
Configuration Updates
ginkgolinterto the enabled linters list in.golangci.ymlCode Fixes
test/e2e/group_list_e2e_test.go: ChangedExpect(len(testGroups)).To(Equal(len(mixedGroupNames)))toExpect(testGroups).To(HaveLen(len(mixedGroupNames)))test/e2e/stdio_proxy_over_streamable_http_mcp_server_test.go: ChangedExpect(len(responses)).To(Equal(2))toExpect(responses).To(HaveLen(2))Benefits
The ginkgolinter helps us:
HaveLen()instead of checkinglen()withEqual())Testing
task lint- all checks pass