Skip to content

Conversation

@dmartinol
Copy link
Collaborator

Fixes #1961

@dmartinol dmartinol changed the title Registry no server count Remove counter of deployed server Sep 19, 2025
dmartinol and others added 10 commits September 19, 2025 15:46
Signed-off-by: Daniele Martinoli <dmartino@redhat.com>
Signed-off-by: Daniele Martinoli <dmartino@redhat.com>
Signed-off-by: Daniele Martinoli <dmartino@redhat.com>
Signed-off-by: Daniele Martinoli <dmartino@redhat.com>
Signed-off-by: Daniele Martinoli <dmartino@redhat.com>
…mance.

- Add logging for clone duration and repository metrics

Signed-off-by: Daniele Martinoli dmartino@redhat.com
Signed-off-by: Daniele Martinoli <dmartino@redhat.com>
Signed-off-by: Daniele Martinoli <dmartino@redhat.com>
Signed-off-by: Daniele Martinoli <dmartino@redhat.com>
Signed-off-by: Daniele Martinoli <dmartino@redhat.com>
@dmartinol dmartinol force-pushed the registry_no_serverCount branch from 48c67cf to b03712e Compare September 19, 2025 13:49
@codecov
Copy link

codecov bot commented Sep 19, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 47.35%. Comparing base (f19cb21) to head (e12359a).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1979      +/-   ##
==========================================
- Coverage   47.43%   47.35%   -0.08%     
==========================================
  Files         232      232              
  Lines       28644    28644              
==========================================
- Hits        13586    13564      -22     
- Misses      14038    14062      +24     
+ Partials     1020     1018       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Collaborator

@RoddieKieley RoddieKieley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed each of the 5 files that were changed. As per the first mcpregistry_types.go file which removed the actual DeployedServerCount int from the MCPRegistryStatus struct, the other removals were all in reference to DeployedServerCount.

@dmartinol dmartinol merged commit 7138ac9 into stacklok:main Sep 22, 2025
27 of 28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Kubernetes MCPRegistry] Remove deployedServerCount field

3 participants