-
Notifications
You must be signed in to change notification settings - Fork 155
Remove counter of deployed server #1979
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Daniele Martinoli <dmartino@redhat.com>
Signed-off-by: Daniele Martinoli <dmartino@redhat.com>
Signed-off-by: Daniele Martinoli <dmartino@redhat.com>
Signed-off-by: Daniele Martinoli <dmartino@redhat.com>
Signed-off-by: Daniele Martinoli <dmartino@redhat.com>
…mance. - Add logging for clone duration and repository metrics Signed-off-by: Daniele Martinoli dmartino@redhat.com Signed-off-by: Daniele Martinoli <dmartino@redhat.com>
Signed-off-by: Daniele Martinoli <dmartino@redhat.com>
Signed-off-by: Daniele Martinoli <dmartino@redhat.com>
Signed-off-by: Daniele Martinoli <dmartino@redhat.com>
48c67cf to
b03712e
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1979 +/- ##
==========================================
- Coverage 47.43% 47.35% -0.08%
==========================================
Files 232 232
Lines 28644 28644
==========================================
- Hits 13586 13564 -22
- Misses 14038 14062 +24
+ Partials 1020 1018 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
RoddieKieley
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed each of the 5 files that were changed. As per the first mcpregistry_types.go file which removed the actual DeployedServerCount int from the MCPRegistryStatus struct, the other removals were all in reference to DeployedServerCount.
Fixes #1961