Replace global logger with context-aware logging in operator #2007
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolves #1830 This change replaces all instances of global logger usage in the ToolHive operator with context-aware logging to preserve trace context for better observability. Changes: - Updated validateRunConfig() to accept context and use log.FromContext() - Updated helper functions in mcpserver_controller.go to use context-aware logging: - ensureRequiredEnvVars() - serviceForMCPServer() - deploymentNeedsUpdate() - generateKubernetesOIDCArgs() - generateConfigMapOIDCArgs() - Removed unused global logger imports - Updated function signatures to accept context.Context parameters - Fixed all calling sites to pass context - Updated test files to accommodate new function signatures - Fixed linting issues (line length violations) All tests pass and no regressions introduced.
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #2007 +/- ##
==========================================
- Coverage 47.58% 47.54% -0.04%
==========================================
Files 232 232
Lines 28646 28655 +9
==========================================
- Hits 13630 13624 -6
- Misses 13989 14010 +21
+ Partials 1027 1021 -6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
dmartinol
reviewed
Sep 24, 2025
RoddieKieley
approved these changes
Sep 24, 2025
Collaborator
RoddieKieley
left a comment
RoddieKieley
left a comment
There was a problem hiding this comment.
Upon a cursory read through it looks good and matches the description. All checks are green so +1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1830
This change replaces all instances of global logger usage in the ToolHive operator with context-aware logging to preserve trace context for better observability.
Changes
validateRunConfig()to accept context and uselog.FromContext()mcpserver_controller.goto use context-aware logging:ensureRequiredEnvVars()serviceForMCPServer()deploymentNeedsUpdate()generateKubernetesOIDCArgs()generateConfigMapOIDCArgs()context.ContextparametersTesting
Impact
This change improves observability by ensuring that trace context is properly preserved throughout the operator's logging, making it easier to correlate logs with distributed traces in production environments.