Skip to content

fixes test assertion that fails intermittently if not exact order match #2180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 13, 2025
Merged

fixes test assertion that fails intermittently if not exact order match #2180

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion pkg/mcp/tool_middleware_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -483,7 +483,12 @@ func TestNewListToolsMappingMiddleware_SSE_Scenarios(t *testing.T) {
// Verify results
assert.Equal(t, "2.0", response.JSONRPC)
assert.Equal(t, float64(1), response.ID)
assert.Equal(t, tt.expected, response.Result.Tools)
// Use ElementsMatch for order-independent comparison of tools
if tt.expected != nil && response.Result.Tools != nil {
assert.ElementsMatch(t, *tt.expected, *response.Result.Tools, "Tools should match regardless of order")
} else {
assert.Equal(t, tt.expected, response.Result.Tools)
}
})
}
}
Expand Down
Loading