Skip to content

Conversation

@ChrisJBurns
Copy link
Collaborator

@ChrisJBurns ChrisJBurns commented Nov 27, 2025

In future we want to be able to merge the default podTemplateSpec and the user provided podTemplateSpec for an MCPRegistry. This PR adds a MergePodTemplateSpecs function that merges a user provided and default podTemplateSpec choosing the user provided one as a preference

Signed-off-by: Chris Burns <29541485+ChrisJBurns@users.noreply.github.com>
@ChrisJBurns ChrisJBurns changed the title adds function that merges podTemplateSpecs. adds function that merges podTemplateSpecs Nov 27, 2025
@github-actions github-actions bot added the size/M Medium PR: 300-599 lines changed label Nov 27, 2025
@codecov
Copy link

codecov bot commented Nov 27, 2025

Codecov Report

❌ Patch coverage is 73.88060% with 35 lines in your changes missing coverage. Please review.
✅ Project coverage is 56.36%. Comparing base (e724609) to head (0fc4fb0).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...md/thv-operator/pkg/registryapi/podtemplatespec.go 73.88% 31 Missing and 4 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2770      +/-   ##
==========================================
+ Coverage   56.29%   56.36%   +0.07%     
==========================================
  Files         319      319              
  Lines       30753    30887     +134     
==========================================
+ Hits        17312    17411      +99     
- Misses      11953    11984      +31     
- Partials     1488     1492       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ChrisJBurns ChrisJBurns changed the title adds function that merges podTemplateSpecs adds MergePodTemplateSpecs that merges podTemplateSpecs Nov 27, 2025
@ChrisJBurns ChrisJBurns enabled auto-merge (squash) November 27, 2025 16:52
@ChrisJBurns ChrisJBurns merged commit 4e36464 into main Nov 27, 2025
32 checks passed
@ChrisJBurns ChrisJBurns deleted the podtemplate-user branch November 27, 2025 17:18
@dmartinol
Copy link
Collaborator

Could you pls link the associated story/issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/M Medium PR: 300-599 lines changed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants