Add RetryDelay to ErrorHandling in WorkflowStep CRD #2776
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2776 +/- ##
==========================================
+ Coverage 56.45% 56.52% +0.06%
==========================================
Files 319 319
Lines 30878 30882 +4
==========================================
+ Hits 17433 17456 +23
+ Misses 11946 11922 -24
- Partials 1499 1504 +5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
github-actions
bot
added
size/S
The VirtualMCPServer CRD's ErrorHandling struct was missing the RetryDelay field that is supported by the implementation. This adds the field to allow users to configure the delay between retry attempts for workflow steps. Changes: - Add RetryDelay field to ErrorHandling struct with duration pattern validation - Update converter to parse and pass through the retry delay - Add comprehensive tests for error handling conversion Fixes #2773 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
JAORMX
force-pushed
the
add-retrydelay-to-errorhandling-crd
branch
from
9e915cb to
d37a3a7
Compare
github-actions
bot
added
size/S
jhrozek
approved these changes
Nov 28, 2025
Contributor
jhrozek
left a comment
jhrozek
left a comment
There was a problem hiding this comment.
I have some nits, but I'll just send them as follow ups, great work
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
RetryDelayfield toErrorHandlingstruct in the VirtualMCPServer CRDThe implementation in
pkg/vmcp/config/config.goalready supportsRetryDelay, but it was missing from the CRD. This allows users to configure the delay between retry attempts for workflow steps:Test plan
Fixes #2773
🤖 Generated with Claude Code