Fix proposal naming validation to only check new files #2788
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The --diff-filter option was missing the equals sign, which could cause git to misinterpret 'A' as a path argument instead of the filter value. This resulted in the validation failing even when only updating existing proposal files. Changes: - Fix --diff-filter syntax from '--diff-filter A' to '--diff-filter=A' - Add '|| true' to grep to handle cases with no matching files - Update comments to clarify the intent 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2788 +/- ##
==========================================
- Coverage 56.45% 56.45% -0.01%
==========================================
Files 319 319
Lines 30878 30878
==========================================
- Hits 17433 17431 -2
- Misses 11946 11948 +2
Partials 1499 1499 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ChrisJBurns
approved these changes
Nov 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
--diff-filtersyntax from--diff-filter Ato--diff-filter=Ain the proposal naming validation workflowAas a path argument instead of the "Added files only" filterTest plan
THV-0597-otel-integration-proposal.md) - validation should pass🤖 Generated with Claude Code